Skip to content

disable bounds check in svs#924

Open
meiravgri wants to merge 1 commit intomainfrom
meiravg_disable_bounds_check_svs
Open

disable bounds check in svs#924
meiravgri wants to merge 1 commit intomainfrom
meiravg_disable_bounds_check_svs

Conversation

@meiravgri
Copy link
Copy Markdown
Collaborator

@meiravgri meiravgri commented Mar 30, 2026

Describe the changes in the pull request

A clear and concise description of what the PR is solving.

Which issues this PR fixes

  1. #...
  2. MOD...

Main objects this PR modified

  1. ...
  2. ...

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Note

Medium Risk
Build-time change that alters SVS runtime validation behavior and could mask out-of-bounds bugs when using the in-tree SVS build. Scope is limited to the non-SVS_SHARED_LIB path in cmake/svs.cmake.

Overview
Disables SVS bounds checks in the vendored build. When SVS_SHARED_LIB is off (building deps/ScalableVectorSearch from source), the CMake now forces SVS_EXPERIMENTAL_CHECK_BOUNDS=OFF via cache before add_subdirectory, changing SVS compilation defaults for that dependency.

Written by Cursor Bugbot for commit 1057155. This will update automatically on new commits. Configure here.

@jit-ci
Copy link
Copy Markdown

jit-ci bot commented Mar 30, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.98%. Comparing base (42fdc90) to head (1057155).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #924   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files         129      129           
  Lines        7574     7574           
=======================================
  Hits         7346     7346           
  Misses        228      228           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant