Skip to content

MOD-14618 Fix race condition when calling indexLabelCount on SVS without locks #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meiravgri merged 4 commits into from
Mar 25, 2026
+16 −8
Merged

MOD-14618 Fix race condition when calling indexLabelCount on SVS without locks #919

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef314b4
proposal to fix flaky test
JoanFM Mar 19, 2026
409ffff
clarify scope
JoanFM Mar 19, 2026
1425e08
fiox preferAdHocSearch and add comment to indexLabelCount()
meiravgri Mar 23, 2026
56d0b33
revert preferAdHocSearch
meiravgri Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions src/VecSim/vec_sim_tiered_index.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,14 +423,22 @@ VecSimDebugInfoIterator *VecSimTieredIndex<DataType, DistType>::debugInfoIterato
.fieldType = INFOFIELD_UINT64,
.fieldValue = {FieldValue{.uintegerValue = info.tieredInfo.bufferLimit}}});

infoIterator->addInfoField(VecSim_InfoField{
.fieldName = VecSimCommonStrings::FRONTEND_INDEX_STRING,
.fieldType = INFOFIELD_ITERATOR,
.fieldValue = {FieldValue{.iteratorValue = this->frontendIndex->debugInfoIterator()}}});
// Acquire shared locks to safely access each sub-index's debug info during background indexing.
// Only hold each lock while accessing its respective index to minimize contention.
{
std::shared_lock<std::shared_mutex> flat_lock(this->flatIndexGuard);
infoIterator->addInfoField(VecSim_InfoField{
.fieldName = VecSimCommonStrings::FRONTEND_INDEX_STRING,
.fieldType = INFOFIELD_ITERATOR,
.fieldValue = {FieldValue{.iteratorValue = this->frontendIndex->debugInfoIterator()}}});
}

infoIterator->addInfoField(VecSim_InfoField{
.fieldName = VecSimCommonStrings::BACKEND_INDEX_STRING,
.fieldType = INFOFIELD_ITERATOR,
.fieldValue = {FieldValue{.iteratorValue = this->backendIndex->debugInfoIterator()}}});
{
std::shared_lock<std::shared_mutex> main_lock(this->mainIndexGuard);
infoIterator->addInfoField(VecSim_InfoField{
.fieldName = VecSimCommonStrings::BACKEND_INDEX_STRING,
.fieldType = INFOFIELD_ITERATOR,
.fieldValue = {FieldValue{.iteratorValue = this->backendIndex->debugInfoIterator()}}});
}
return infoIterator;
};
Loading