Open
Conversation
- Replace deprecated logging.warn() with logging.warning() - Remove unused OPEN_PORT constant - Fix bare except clauses with specific exceptions - Fix service_detection hardcoded paths with dynamic resolution - Improve OS detection with efficient TTL lookup and range detection - Add type hints to Scanner class - Fix time module import
- Return None instead of raw exception object for consistent API - Add logging.error() to record scan failures for debugging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code quality improvements and bug fixes to improve maintainability and reliability.
Changes
Bug Fixes
logging.warn()withlogging.warning()(deprecated since Python 3.3)except:clauses with specific exceptions (IndexError,ValueError,AttributeError)Noneinstead of raw exception object for consistent API contracttimemodule import (was usingtime.sleep()but only importingsleep)Code Quality
OPEN_PORT = 80constantScannerclass (__init__,port_scan)service_detection.py- now auto-detects path relative to module locationservice_detection.pyfor debugging failed scansOS Detection Enhancement
"Windows (TTL: 120)")Testing
python -m py_compile)--helpcommand works correctly