WIP: [Storage] Replace HPP skip fixtures with hpp pytest marker#4904
Open
jpeimer wants to merge 1 commit into
Open
WIP: [Storage] Replace HPP skip fixtures with hpp pytest marker#4904jpeimer wants to merge 1 commit into
jpeimer wants to merge 1 commit into
Conversation
Replace skip_test_if_no_hpp_sc and skip_test_if_no_hpp_requested fixtures with a pytest.mark.hpp marker on HPP test modules. HPP tests are now deselected by default and only collected when -m hpp is passed. The marker integrates with compound expressions: -m "tier2 and storage" excludes HPP tests, -m "(tier2 and storage) or hpp" includes them Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: Jenia Peimer <jpeimer@redhat.com>
Contributor
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-3
requested review from
Ahmad-Hafe,
acinko-rh,
dalia-frank,
dshchedr,
ema-aka-young,
kgoldbla,
kshvaika,
rnetser and
vsibirsk
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
rnetser
reviewed
May 19, 2026
Comment on lines
+552
to
+559
| def filter_hpp_tests(items: list[Item], config: Config) -> list[Item]: | ||
| marker_expression = config.getoption("-m") | ||
| if not marker_expression or "hpp" not in marker_expression: | ||
| discard_tests, items_to_return = remove_tests_from_list(items=items, filter_str="hpp") | ||
| config.hook.pytest_deselected(items=discard_tests) | ||
| return items_to_return | ||
|
|
||
| return items |
Collaborator
There was a problem hiding this comment.
why is this needed?
pytest collects based on the provided markers
it is a good approach to mark the tests that require hpp with this marker
Contributor
Author
There was a problem hiding this comment.
by default, these hpp tests will be collected when we just pass "-m storage and tier2", so we need a way to not-select them by default, and only select them when we pass the hpp marker
| remote_cluster: Tests that require a remote cluster | ||
|
|
||
| ## Required operators | ||
| hpp: Tests that require the HostPath Provisioner. Only collected when -m hpp is passed |
Collaborator
There was a problem hiding this comment.
Only collected when -m hpp is passed - please remove, this is pytest built-in behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description:
Replace
skip_test_if_no_hpp_scandskip_test_if_no_hpp_requestedfixtures with apytest.mark.hppmarker on HPP test modules. HPP tests are now deselected by default and only collected when -m hpp is passed.The marker integrates with compound expressions:
-m "tier2 and storage"excludes HPP tests,-
m "(tier2 and storage) or hpp"includes themAssisted-by: Claude noreply@anthropic.com
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket: