Remove in-need parameter on main businesses page#378
Open
brianjhanson wants to merge 1 commit intoRebuild-Black-Business:mainfrom
Open
Remove in-need parameter on main businesses page#378brianjhanson wants to merge 1 commit intoRebuild-Black-Business:mainfrom
brianjhanson wants to merge 1 commit intoRebuild-Black-Business:mainfrom
Conversation
brianjhanson
requested review from
domitriusclark,
magnificode,
mbifulco and
racedale
as code owners
|
Deploy request for rebuild-black-business accepted. Accepted with commit b5ee6b5 https://app.netlify.com/sites/rebuild-black-business/deploys/5fae8f2c0da4a100072b803d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure this is the best way to fix this, but I think it's at least a way.
This PR alters the
searchingInNeedfunction within thebusinessestemplate to return 'false' both when thelocation.pathnameis/businesses/alland when it is/businesses. The latter should only match when/businessesis the only URL path and should account for an optional trailing slash.Fixes #370
Pages/Interfaces that will change
Screenshots / video of changes
Steps to test
/businesses/allpage