Report installed plugin version in System Info#39
Open
jgalea wants to merge 1 commit into
Open
Conversation
When the v4 engine runs inside a newer package (v5 in classic mode), the System Info tool printed WPRSS_VERSION (the engine's internal version, e.g. 4.23.13) as the Plugin Version, even though the installed package is newer. That reads like a failed update and generates support tickets. Show the real installed version from the main plugin file header instead, and keep the engine version on a separate line when it differs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes System Info reporting the engine's internal version instead of the installed plugin version. Fixes #38.
In classic mode (a v4-origin site running inside a newer package),
includes/system-info.phpprintedWPRSS_VERSIONas the Plugin Version. That constant is the v4 engine's internal version (e.g.4.23.13) and is used across the engine for update checks and asset versioning, so it can't be bumped to match the package. The result was System Info showing an old number while the Plugins screen and Site Health correctly showed the installed version, which reads like a failed update and generates support tickets.The change reads the real installed version from the main plugin file header (
WPRSS_FILE_CONSTANT) viaget_file_data()and prints that as Plugin Version. When the engine's internal version differs, it is shown on a separateEngine Versionline so the engine in use is still visible for debugging. In a standalone v4 install the package and engine versions are identical, so the output is unchanged there.Display-only change; no engine constants or update logic are touched.