Open
Conversation
Added in an if/elif/else statement that will check the socket host. - If the socket host is zeus, then it will import the zeus submit script and settings - Else if the socket host is atlas, then it will import the atlas submit script and settings - Else if the socket host is not recognised, then it will just import the general submit script and settings.
File that provides the template for the submission file for zeus
Provides the settings for Zeus server
The template for the atlas server submit file
The settings for the atlas server if used
alongd
reviewed
Jan 29, 2023
Member
alongd
left a comment
alongd
left a comment
There was a problem hiding this comment.
Thanks! I added a few minor comments
| 'local': { | ||
| 'cluster_soft': 'PBS', | ||
| 'cpus': 16, | ||
| 'max mem': 40, # GB |
|
|
||
| # Submission scripts stored as a dictionary with software as the primary key. | ||
| submit_scripts = { | ||
| # 'rmg': """#!/bin/bash -l |
Member
There was a problem hiding this comment.
can remove the commented out section, this is an example for a Slurm server, it's enough to have it in the general submit.py file
|
|
||
| # Submission scripts stored as a dictionary with software as the primary key. | ||
| submit_scripts = { | ||
| # 'rmg': """#!/bin/bash -l |
Member
There was a problem hiding this comment.
can remove the commented out section, this is an example for a Slurm server, it's enough to have it in the general submit.py file
| servers = { | ||
| 'local': { | ||
| 'cluster_soft': 'PBS', | ||
| 'cpus': 16, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, I would like to move forward with having the Zeus and Atlas settings part of the repo so that when updates do need to occur, it will be pushed to all users for those servers rather than them needing to check out the DRG repo. Additionally, the changes will not affect a user if they use their own local settings