Skip to content

feat: Use fullscreen dialog for selectors#3235

Open
Ushie wants to merge 2 commits intomainfrom
feat/improve-selections
Open

feat: Use fullscreen dialog for selectors#3235
Ushie wants to merge 2 commits intomainfrom
feat/improve-selections

Conversation

@Ushie
Copy link
Copy Markdown
Member

@Ushie Ushie commented Mar 28, 2026

Screen_Recording_20260328_061006_ReVanced.Manager.Debug.mp4

@Ushie Ushie marked this pull request as ready for review March 28, 2026 03:09
@PalmDevs
Copy link
Copy Markdown
Member

Can the overlines be replaced with a single section header/label instead?


<string name="sideeffect_restart">Restart the app to see changes</string>
<string name="sideeffect_no_network">You’re offline. Check your internet connection.</string>
<string name="source_selector_category_downloaded">Previously downloaded</string>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "previously" is misleading here. I assume once cache is cleared, the apps would disappear. Just say "Downloaded" maybe?

@PalmDevs
Copy link
Copy Markdown
Member

I don't like this at all:

image

@Ushie
Copy link
Copy Markdown
Member Author

Ushie commented Mar 28, 2026

Maybe we can make Version immutable when its Any, so basically you just cant reach that screen?

Afterall there's no purpose to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants