-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix fread clipboard handling on Windows (fixes #1292) #7640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AmanKashyap0807
wants to merge
8
commits into
Rdatatable:master
Choose a base branch
from
AmanKashyap0807:fix-fread-clipboard-issue1292
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+83
−0
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
546de99
Fix fread clipboard handling on Windows (fixes #1292)
AmanKashyap0807 c68136d
addressing linting
AmanKashyap0807 43b8a22
Tweak fread clipboard checks and error handling on Windows
AmanKashyap0807 b5a2a7c
Add Linux (X11/Wayland) and macOS clipboard support to fread
AmanKashyap0807 a8abf6c
Merge branch 'master' into fix-fread-clipboard-issue1292
AmanKashyap0807 6c34cba
correct wl-paste redundancy and replace stopf with warning for non su…
AmanKashyap0807 b95ca4c
fix linter warning of CI workflow
AmanKashyap0807 5e33fe9
Address review feedback for fread clipboard support
AmanKashyap0807 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on non windows and non-unix this will error because of
trimws(clip)butclipwas never assignedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now added
return(data.table())inside the else block for unsupported platforms.