Nifty raven mineable assets patch 1.1#1254
Open
NiftyRaven wants to merge 3 commits intoRavenProject:masterfrom
Open
Nifty raven mineable assets patch 1.1#1254NiftyRaven wants to merge 3 commits intoRavenProject:masterfrom
NiftyRaven wants to merge 3 commits intoRavenProject:masterfrom
Conversation
This commit introduces a standardized pull request template to the repository. The template aims to streamline the process of submitting pull requests by ensuring that all necessary information is provided upfront, which facilitates a more efficient and effective review process. Key components of the template include: - Checklist for commit message adherence, test addition, documentation updates, and code linting. - Detailed sections for describing the type of change, current and new behavior, and any breaking changes. - Guidance for prefacing pull request titles with relevant areas such as Build, Consensus, GUI, Net, and more. - Instructions for contributors to label work-in-progress (WIP) pull requests and include justification and reasoning for their changes. - Emphasis on focused patchsets, with separate sections for features, refactoring, and decision-making processes. - Detailed peer review guidelines and an explanation of the project's philosophy on pull requests. This addition aligns with the project's commitment to maintaining high-quality contributions and providing clear guidance to contributors. The template will be automatically applied to all new pull requests, ensuring consistency and thoroughness across the project.
- Added new RPC command `issuemineable` to support the creation and distribution of mineable assets. - Added new RPC command `issuemineabletestrun` to simulate mineable asset issuance and calculate costs and distribution timeframe. - Included new commands in the RPC command table under the "mineable" category.
- Revised/Completed new RPC command `issuemineable` to support the creation and distribution of mineable assets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issuemineableto support the creation and distribution of mineable assets.