fix: update sendfromaddress index matching#1223
Open
michaelmcshinsky wants to merge 3 commits intoRavenProject:masterfrom
Open
fix: update sendfromaddress index matching#1223michaelmcshinsky wants to merge 3 commits intoRavenProject:masterfrom
michaelmcshinsky wants to merge 3 commits intoRavenProject:masterfrom
Conversation
michaelmcshinsky
force-pushed
the
rpcwallet-sendfromaddress
branch
from
5ab4628 to
40d177c
Compare
michaelmcshinsky
force-pushed
the
rpcwallet-sendfromaddress
branch
4 times, most recently
from
ebbd9d2 to
159bc4a
Compare
* Fix indicies to match correct counterparts * Fix inidices to correct index where index specified does not exist
michaelmcshinsky
force-pushed
the
rpcwallet-sendfromaddress
branch
from
159bc4a to
eea7554
Compare
NiftyRaven
approved these changes
May 24, 2024
NiftyRaven
left a comment
NiftyRaven
left a comment
There was a problem hiding this comment.
Approval Review for PR #1223
The proposed changes in rpcwallet.cpp effectively adjust the parameter indices in functions such as sendtoaddress, sendfromaddress, and sendmany. These adjustments ensure proper parsing and assignment of coin_control.m_confirm_target and correct the indices for FeeModeFromString. These modifications enhance the accuracy and reliability of the wallet RPC commands, contributing to the overall stability of the code. The changes are well-implemented and straightforward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.