Add extra required data to the track_event call when creating a school

[jamiebenstead]

Status

• Closes
• Related to

Description of what's been done

• Add first_landing_page and marketing_preference data when saving the School - Created event

[github-actions]

Test coverage

92.05% line coverage reported by SimpleCov.
Run: https://github.com/RaspberryPiFoundation/editor-api/actions/runs/28438562270

[zetter-rpf]

I'm wondering if it would be easier to query in the data warehouse if all of the event properties were at the same level. It might just be harder to document and query if some are nested inside other attributes. This means we could query on events.properties['utm_source'] rather than events.properties['marketing_params']['utm_source'].

You should be able to do this by spatting the marketing parameters:

track_event('School - Created', **marketing_parameters, @school.id:, first_landing_page: params[:first_landing_page])

[zetter-rpf]

Great. added a suggestion - let me know if you think it's worth doing.

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 390cb3a. Configure here.}

[Copilot]

Pull request overview

This PR updates the school creation analytics event so additional attribution metadata is included when a school is created via the REST API.

Changes:

• Expands the School - Created track_event call to include first_landing_page and flattened marketing parameters.
• Adds a request spec asserting that marketing_parameters keys become top-level event properties (and the nested hash is not stored).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
spec/features/school/creating_a_school_spec.rb	Adds coverage ensuring marketing parameters are recorded as top-level event properties.
app/controllers/api/schools_controller.rb	Extends School - Created event tracking to include marketing attribution fields.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[zetter-rpf]

The track_event call looks good
I saw the comments from cursor and copilot - do you think they could be problems?

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

[zetter-rpf]

Nice one