Merged
Conversation
- After seeing the flakiness, I've endured a bit the test to ensure is idempotent and we can run without flakyness
Test coverage90.09% line coverage reported by SimpleCov. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes flaky/accumulative behavior in the test_seeds:create rake task by preventing re-seeding into an already-seeded test school, and adds a spec asserting the task is idempotent to avoid future regressions.
Changes:
- Update
test_seeds:createto detect an existing seeded school by ID and no-op instead of re-creating seed data. - Add an RSpec example verifying re-invoking the rake task doesn’t change counts for classes/lessons/projects.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lib/tasks/test_seeds.rake |
Prevents duplicate seed creation by skipping the seeding transaction when the test school already exists. |
spec/lib/test_seeds_spec.rb |
Adds an idempotency test to ensure the seeding task doesn’t create duplicates when invoked multiple times. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zetter-rpf
approved these changes
Mar 13, 2026
Contributor
zetter-rpf
left a comment
There was a problem hiding this comment.
Great spot on the id/code miss-match
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported:
Updated rake task to avoid duplicating Lesson.
Added a test to make sure idempotency on this rake task.
Diff seems bigger than it is, only small replacement.