Conversation
- district_nces_id now generates 7 digits instead of 12 - we were using school id instead
|
We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please complete this form and we'll get you added and review your contribution as soon as possible. |
There was a problem hiding this comment.
Pull request overview
This PR makes US-specific school seeding deterministic and valid by aligning generated district_nces_id with the model’s 7-digit validation and adding a targeted spec to cover the US branch.
Changes:
- Generate a 7-digit
district_nces_idwhen seeding US schools to satisfy model validation. - Add an RSpec context that stubs
Faker::Address.country_codetoUSand asserts required US district fields are populated.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/lib/test_seeds_spec.rb | Adds deterministic US-country seeding coverage and asserts district fields + owner lessons are created correctly. |
| lib/tasks/seeds_helper.rb | Fixes US district_nces_id generation to a 7-digit string to match School validations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test coverageSimpleCov coverage data was unavailable for this run. |
No description provided.