Skip to content

fix: Improve narration of modifier keys #9926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonfunko merged 1 commit into from
May 22, 2026
+11 −11
Merged

fix: Improve narration of modifier keys #9926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/blockly/msg/json/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"@metadata": {
"author": "Ellen Spertus <ellen.spertus@gmail.com>",
"lastupdated": "2026-05-21 08:19:50.563628",
"lastupdated": "2026-05-22 09:11:23.194850",
"locale": "en",
"messagedocumentation": "qqq"
},
Expand Down Expand Up @@ -437,14 +437,14 @@
"CHROME_OS": "ChromeOS",
"LINUX": "Linux",
"UNKNOWN": "Unknown",
"CONTROL_KEY": "Ctrl",
"COMMAND_KEY": "⌘ Command",
"OPTION_KEY": "⌥ Option",
"CONTROL_KEY": "Control",
"COMMAND_KEY": "Command",
"OPTION_KEY": "Option",
"ALT_KEY": "Alt",
"ENTER_KEY": "Enter",
"BACKSPACE_KEY": "Backspace",
"DELETE_KEY": "Delete",
"ESCAPE": "Esc",
"ESCAPE": "Escape",
"TAB_KEY": "Tab",
"SHIFT_KEY": "Shift",
"CAPS_LOCK_KEY": "Caps Lock",
Expand Down
8 changes: 4 additions & 4 deletions packages/blockly/msg/messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1745,13 +1745,13 @@ Blockly.Msg.LINUX = 'Linux';
Blockly.Msg.UNKNOWN = 'Unknown';
/** @type {string} */
/// {{Optional}} Representation of the Control key used in keyboard shortcuts.
Blockly.Msg.CONTROL_KEY = 'Ctrl';
Blockly.Msg.CONTROL_KEY = 'Control';
/** @type {string} */
/// {{Optional}} Representation of the Mac Command key used in keyboard shortcuts.
Blockly.Msg.COMMAND_KEY = '⌘ Command';
Blockly.Msg.COMMAND_KEY = 'Command';
/** @type {string} */
/// {{Optional}} Representation of the Mac Option key used in keyboard shortcuts.
Blockly.Msg.OPTION_KEY = '⌥ Option';
Blockly.Msg.OPTION_KEY = 'Option';
/** @type {string} */
/// {{Optional}} Representation of the Alt key used in keyboard shortcuts.
Blockly.Msg.ALT_KEY = 'Alt';
Expand All @@ -1766,7 +1766,7 @@ Blockly.Msg.BACKSPACE_KEY = 'Backspace';
Blockly.Msg.DELETE_KEY = 'Delete';
/** @type {string} */
/// {{Optional}} Representation of the Escape key used in keyboard shortcuts.
Blockly.Msg.ESCAPE = 'Esc';
Blockly.Msg.ESCAPE = 'Escape';
/** @type {string} */
/// {{Optional}} Representation of the Tab key used in keyboard shortcuts.
Blockly.Msg.TAB_KEY = 'Tab';
Expand Down
4 changes: 2 additions & 2 deletions packages/blockly/tests/mocha/keyboard_movement_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,8 +569,8 @@ suite('Keyboard-driven movement', function () {
assert.equal(
toastSpy.args[0][1]['message'],
Blockly.utils.userAgent.MAC
? 'Hold ⌘ Command and use arrow keys to move freely, then Enter to accept the position.'
: 'Hold Ctrl and use arrow keys to move freely, then Enter to accept the position.',
? 'Hold Command and use arrow keys to move freely, then Enter to accept the position.'
: 'Hold Control and use arrow keys to move freely, then Enter to accept the position.',
);
sinon.assert.calledOnce(beepSpy);
beepSpy.restore();
Expand Down
Loading