Skip to content

fix: Fix unexpected toast when committing a move with Space#9920

Merged
gonfunko merged 1 commit into
v13from
space-jam
May 21, 2026
Merged

fix: Fix unexpected toast when committing a move with Space#9920
gonfunko merged 1 commit into
v13from
space-jam

Conversation

@gonfunko
Copy link
Copy Markdown
Contributor

The basics

The details

Resolves

Fixes #9915

Proposed Changes

This PR fixes an issue where committing a move with Space triggered a toast prompting the user to use arrow keys to navigate a block. This is because move mode registers a shortcut under the same keys as all other non-move-mode-related shortcuts to intercept them and commit the move before passing through to the other shortcuts in order to prevent chaos when running shortcuts targeting mid-move blocks. The list of move-related-shortcuts that are excluded from this fallback handler did not include Space, so the fallback handler (which allowed bubbling the shortcut to other handlers) was registered under Space in priority to the actual end-move handler, which does not allow bubbling. This led to the Space key bubbling to the perform action shortcut, which shows this toast when a user attempts to act on a block.

@gonfunko gonfunko requested a review from a team as a code owner May 21, 2026 19:12
@gonfunko gonfunko requested a review from maribethb May 21, 2026 19:12
@github-actions github-actions Bot added the PR: fix Fixes a bug label May 21, 2026
@gonfunko gonfunko merged commit 8e3bd12 into v13 May 21, 2026
9 checks passed
@gonfunko gonfunko deleted the space-jam branch May 21, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants