feat: Adjacent label fields are combined when composing ARIA labels#9873
Open
lizschwab wants to merge 1 commit into
Open
feat: Adjacent label fields are combined when composing ARIA labels#9873lizschwab wants to merge 1 commit into
lizschwab wants to merge 1 commit into
Conversation
lizschwab
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9855
Proposed Changes
When composing an ARIA label, adjacent field labels will now be combined together so that they no longer have commas separating them.
Reason for Changes
The way some custom blocks are composed, multiple field labels are sometimes generated which are visually part of the same label but which were being separated by commas in the ARIA label. This fixes it so that the screen reader and visual experience are closer aligned.
Test Coverage
Added and updated unit tests and manually tested with a custom block in the playground.