fix: always store initial drag connections#9851
Merged
mikeharv merged 1 commit intoMay 11, 2026
Merged
Conversation
gonfunko
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
This fixes an untracked bug that could cause
revertDrag()to work incorrectly when the current drag had previously stored an initial valid parent or child connection.Screen.Recording.2026-05-11.at.3.44.51.PM.mov
Proposed Changes
This change guarantees
BlockDragStrategy.storeInitialConnections()will be called as part of everystartMove.Reason for Changes
This
BlockDragStrategymethod relies onstoreInitialConnections()to store the current parent and child blocks at the start of a drag. However, this was only happening if a move was started that should cause a disconnect.Screen.Recording.2026-05-11.at.3.42.50.PM.mov