feat: Added additional keyboard shortcuts for context menu#9845
Open
lizschwab wants to merge 2 commits intoRaspberryPiFoundation:v13from
Open
feat: Added additional keyboard shortcuts for context menu#9845lizschwab wants to merge 2 commits intoRaspberryPiFoundation:v13from
lizschwab wants to merge 2 commits intoRaspberryPiFoundation:v13from
Conversation
lizschwab
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes RaspberryPiFoundation/blockly-keyboard-experimentation#622
Proposed Changes
Adds context menu shortcuts for Shift+F10 and the Menu key.
Reason for Changes
These are common shortcuts for the context menu in Windows.
Test Coverage
Added unit tests for validating the context menu appears from a block, from a workspace comment, and from the workspace when pressing these key combinations. Tested manually (my keyboard does have a menu button).