feat: Relax access restrictions on BlockDragStrategy - #10273
Open
gonfunko wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR switches a number of fields and methods in
BlockDragStrategyfromprivatetoprotected.Reason for Changes
BlockDragStrategycan reasonably be expected to be subclassed, and the existing access restrictions made this challenging. The members that have been changed are those that I'm reasonably confident are stable, would likely be needed by subclasses, and have not-hideous APIs. These changes would ease or enable implementation of several drag strategies in Scratch, for e.g. duplicating blocks on drag, using a parent block as a drag target instead of the clicked block, and always using a new ID when dragging blocks out of the flyout to the main workspace.