fix: nest trashcan and zoom as separate focus trees - #10271
Open
mikeharv wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9792
Proposed Changes
Make the trashcan and each zoom control their own
IFocusableTree(nested under the workspace for DOM lookup), while keeping them as native Tab stops.WorkspaceControlNavigator, a no-op navigator so arrow keys do not move focus from chrome into blocksFocusManager; nest them fromWorkspaceSvg.getNestedTrees()FOCUSABLEcomponent registration for these controlsINavigatorso workspace-control navigators can implement the navigator API without extendingNavigator(avoids a circular import seen in the first commit)Reason for Changes
Trash and zoom live inside the workspace's focusable
svgGroup_and are also extra tab stops. This made them feel like both separate tab stops and part of the workspace. Tab skipped the workspace if a workspace control had previously been focused, and arrow keys jumped focus from the controls onto blocks.Nesting them as separate trees fixes this.
Test Coverage
Additional Information
This was the first attempt at addressing the linked issue. An alternative was pursued later which removed the
IFocusableimplementation from the trash and zoom controls altogether. If that work is approved/merged, this branch can be closed. That work is here: