chore: move sample-app into a private plugin - #10230
Merged
Merged
Conversation
lizschwab
marked this pull request as draft
August 4, 2026 22:07
lizschwab
marked this pull request as ready for review
August 4, 2026 23:08
maribethb
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves #10228
Proposed Changes
Move sample-app and sample-app-ts into a private plugin and update dev-create to point to the new location in the prepack script.
Reason for Changes
Dev-tools needs sample-app to be co-located in order to copy the sample app in.
Test Coverage
No tests added. Tested locally by ensuring the prepack script runs.