docs: reorganize contribute to blockly docs - #10188
Conversation
mikeharv
left a comment
There was a problem hiding this comment.
Pulled and skimmed changes. This reorganization makes sense to me!
maribethb
left a comment
There was a problem hiding this comment.
lots of small suggestions, the only thing that really feels out of place to me is the section on headless mode.
| calls the super (which saves the colour) and also *applies* that colour | ||
| to the rendered block. | ||
|
|
||
| ### Headless workspaces |
There was a problem hiding this comment.
This section doesn't really feel like it fits here imo. it's too specific and not really about contributing to blockly. if we don't already have something about running headless, it's useful content, but more for users who want headless mode, not contributors.
There was a problem hiding this comment.
that's fair, it also starts to read more like a tutorial than a guide. I just removed this section and I'll make an issue about the lack of info on headless workspaces
The basics
The details
Resolves
Fixes #10137
Proposed Changes & Reasons for Changes
Section: Get Started
pr_review_process, with content merged intowrite_a_good_prwrite_a_good_prto make it more succinct, and combined redundant steps of thepr_review_processmaterial.write_a_good_issueissue_labelspagewrite_a_good_prandwrite_a_good_issueplaygroundanddevelopment_toolsinto Contribute to Core sectionSection: Contribute to Core
core_tourto Core Architecture folderadd_localization_token,translating, andklingon.unit_testingandplaygroundare now in their own subfolder within Contribute to Core called Testingadvancedandbuildingare also now in their own subfolder within Contribute to Core called Building and Compilation.Also changed
sidebars.jsand_redirectsto reflect all of these changes.Test Coverage
N/A, but tested all links
Additional Information
Contribute to Samples docs remain untouched. These docs will need to be changed again a decent amount once the samples are moved into core (#7755), so major changes can/should wait until then so that we don't have to do two major overhauls of these docs in a row.