Animate the keyboard in the music player#1325
Merged
Rangi42 merged 9 commits intoRangi42:masterfrom Jan 24, 2026
Merged
Conversation
Sprites at 0 have the same penalty as sprites on screen Avoiding this costs nothing and eases up on hblank timing
Fixes a jitter that previously happened near the top of the frame
Saves 2 bytes
Owner
|
This makes a surprisingly big difference in being able to follow the music as it's played! I added more contrast between the pressed keys and the notes: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could probably look better, some contrast between notes and key colours, but thats outside my skill set