Add quantity selection for selling items to ingredient/stone buyers#1302
Merged
Add quantity selection for selling items to ingredient/stone buyers#1302
Conversation
Co-authored-by: vulcandth <6394873+vulcandth@users.noreply.github.com>
…rotection, remove unused code Co-authored-by: vulcandth <6394873+vulcandth@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix selling multiple ingredients and stones at once
Add quantity selection for selling items to ingredient/stone buyers
Dec 2, 2025
Rangi42
reviewed
Dec 2, 2025
Co-authored-by: vulcandth <6394873+vulcandth@users.noreply.github.com>
vulcandth
requested changes
Dec 3, 2025
…, fix RGBDS syntax for 24-bit money value Co-authored-by: vulcandth <6394873+vulcandth@users.noreply.github.com>
…tems Co-authored-by: vulcandth <6394873+vulcandth@users.noreply.github.com>
…ffer2=low) Co-authored-by: vulcandth <6394873+vulcandth@users.noreply.github.com>
Contributor
Author
Fixed in f4fb96d. The issue was that I had the high/low bytes swapped when reading the CountItem result. CountItem stores the high byte in wBuffer1 and low byte in wBuffer2, but I was reading them in reverse order. Now correctly limits selection to the actual quantity in your bag. |
vulcandth
approved these changes
Jan 17, 2026
Collaborator
vulcandth
left a comment
There was a problem hiding this comment.
Did some tweaking and in-game testing looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: Add quantity selection for selling ingredients and stones
Summary
Successfully implemented quantity selection for selling items to the three "maniacs" in the game. Fixed critical bug where high/low bytes were swapped when reading CountItem results, which caused the quantity limit to not work correctly. Now properly limits selection to actual items in bag.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.