Refactor: Where possible, utilise native xq flags for XML parsing and extraction#406
Draft
Crosenhain wants to merge 4 commits intoRandomNinjaAtk:mainfrom
Draft
Refactor: Where possible, utilise native xq flags for XML parsing and extraction#406Crosenhain wants to merge 4 commits intoRandomNinjaAtk:mainfrom
Crosenhain wants to merge 4 commits intoRandomNinjaAtk:mainfrom
Conversation
Author
|
Hmm this actually appears to be a difference in xq versions between my lidarr and *arr instances that caused me to look at this in the first place... |
Author
|
I dug a bit more, the I did discover that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the XML parsing logic across all scripts (Lidarr, Radarr, Readarr, Sonarr, and Universal) to use xq's built-in extraction flags rather than piping outputs through jq, wherever possible. Where it isn't possible (eg. where jq handles things better), tell xq to output json using the -j flag.
Key Changes: