Skip to content

Fix mutate-changes failing on pull_request CI events #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaszpatrzek wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix mutate-changes failing on pull_request CI events #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54e57f2
Fix mutate-changes failing on pull_request CI events
tomaszpatrzek Jun 22, 2026
3bf71cc
Treat git null SHA as missing base in mutate-changes
tomaszpatrzek Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pricing-mutate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ jobs:
- name: Run incremental mutation testing
run: make -C domains/pricing mutate-changes
env:
GIT_BASE_SHA: ${{ github.event_name == 'push' && github.event.before || '' }}
GIT_BASE_SHA: ${{ github.event_name == 'push' && github.event.before || github.event.pull_request.base.sha }}
2 changes: 1 addition & 1 deletion .github/workflows/rails_application-mutate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,4 @@ jobs:
DATABASE_URL: "postgres://postgres:secret@localhost:5432/cqrs-es-sample-with-res_test"
RAILS_ENV: test
MUTANT_OPTS: --jobs 4
GIT_BASE_SHA: ${{ github.event_name == 'push' && github.event.before || '' }}
GIT_BASE_SHA: ${{ github.event_name == 'push' && github.event.before || github.event.pull_request.base.sha }}
4 changes: 3 additions & 1 deletion apps/rails_application/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ else
@bundle exec mutant run $(MUTANT_OPTS)
endif

GIT_BASE_SHA ?= $(shell git merge-base HEAD origin/master)
# Fall back to merge-base when GIT_BASE_SHA is empty or the git null SHA
# (push of a new branch sets github.event.before to 0000…0).
GIT_BASE_SHA := $(or $(filter-out 0000000000000000000000000000000000000000,$(GIT_BASE_SHA)),$(shell git merge-base HEAD origin/master))

mutate-changes: ## Run incremental mutation tests on changes
@echo "Running incremental mutation tests against $(GIT_BASE_SHA)..."
Expand Down
4 changes: 3 additions & 1 deletion domains/pricing/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
GIT_BASE_SHA ?= $(shell git merge-base HEAD origin/master)
# Fall back to merge-base when GIT_BASE_SHA is empty or the git null SHA
# (push of a new branch sets github.event.before to 0000…0).
GIT_BASE_SHA := $(or $(filter-out 0000000000000000000000000000000000000000,$(GIT_BASE_SHA)),$(shell git merge-base HEAD origin/master))

install:
@bundle install
Expand Down
Loading