[Chore] Add CLAUDE.md and new-operator skill#152
Open
zacharyvincze wants to merge 5 commits into
Open
Conversation
zacharyvincze
requested review from
Copilot,
jeffqjiangNew,
msiddaiah and
rrawther
There was a problem hiding this comment.
Pull request overview
Adds Claude Code metadata and a new-operator skill intended to scaffold rocCV operators end-to-end (C++ API, kernels, pybind11, and tests) to speed up new operator development.
Changes:
- Added
CLAUDE.mdwith build/test commands and repo architecture notes. - Added
.claude/skills/new-operator/skill definition plus C++/Python scaffolding templates for a new operator. - Documented the skill’s workflow/spec placeholders in
SKILL.md.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
CLAUDE.md |
New contributor/agent-facing guidance for building, testing, and navigating rocCV. |
.claude/skills/new-operator/SKILL.md |
Defines the new-operator skill and the spec→template substitution contract. |
.claude/skills/new-operator/templates/op_NAME.hpp.template |
C++ public operator header template (IOperator subclass). |
.claude/skills/new-operator/templates/op_NAME.cpp.template |
C++ operator implementation template (validation + dispatch + kernel calls). |
.claude/skills/new-operator/templates/NAME_device.hpp.template |
HIP device kernel template (pass-through placeholder). |
.claude/skills/new-operator/templates/NAME_host.hpp.template |
CPU kernel template (pass-through placeholder). |
.claude/skills/new-operator/templates/py_op_NAME.hpp.template |
pybind11 header template for Python operator bindings. |
.claude/skills/new-operator/templates/py_op_NAME.cpp.template |
pybind11 implementation template for Python operator bindings. |
.claude/skills/new-operator/templates/test_op_NAME.cpp.template |
C++ test template (negative cases + golden-model harness stub). |
.claude/skills/new-operator/templates/test_op_NAME.py.template |
Python pytest template (op vs _into metadata parity). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rrawther
approved these changes
May 21, 2026
rrawther
left a comment
rrawther
left a comment
There was a problem hiding this comment.
Looks promising for adding new operator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds metadata for Claude Code to help with repository navigation and best practices. It also adds a skill:
new-operatorwhich automatically scaffolds new operator implementations.