Skip to content

[release/2.9] UT fixes#2913

Open
dnikolaev-amd wants to merge 13 commits intorelease/2.9from
dnikolaev/therock_rel2.9_fixes
Open

[release/2.9] UT fixes#2913
dnikolaev-amd wants to merge 13 commits intorelease/2.9from
dnikolaev/therock_rel2.9_fixes

Conversation

@dnikolaev-amd
Copy link
Copy Markdown

@dnikolaev-amd dnikolaev-amd commented Jan 17, 2026 •
edited
Loading

PR to fix release/2.9

Skipped tests:

  • distributed/_tools/test_sac_ilp.py::TestSACILP::test_sac_ilp_case1 - CUDA focused, failed on ROCm
  • test_type_hints.py::TestTypeHints::test_doc_examples - disabled on upstream
  • profiler/test_profiler.py::TestProfiler::test_profiler_cuda_sync_events - failed on ROCm
  • profiler/test_profiler.py::TestProfiler::test_mem_leak - failed on MI200/MI350

Fixed tests:

  • export/test_export_opinfo.py::TestExportOpInfoCPU::test_fake_export_*
  • functorch/test_ops.py::TestOperatorsCUDA::test_jvpvjp_nn_functional_conv3d_cuda_float32
  • functorch/test_ops.py::TestOperatorsCUDA::test_vjp_nn_functional_conv3d_cuda_float32
  • inductor/test_aot_inductor.py::AOTInductorTestABICompatibleGpu::test_aoti_debug_printer_sym_inputs_cuda
  • inductor/test_benchmark_fusion.py::AOTInductorTestABICompatibleGpu::test_aoti_debug_printer_sym_inputs_cuda
  • inductor/test_torchinductor_opinfo.py::TestInductorOpInfoCPU::test_comprehensive_*
  • inductor/test_unbacked_symints.py::TestUnbackedSymintsCUDA::test_triton_kernel_grid_cuda
  • profiler/test_profiler.py::TestProfiler::test_disable_external_correlation
  • profiler/test_profiler.py::TestProfiler::test_dynamic_toggle
  • test_flop_counter.py::TestFlopCounter::test_scaled_mm
  • test_nn.py::TestNN::test_rnn_check_device
  • test_sparse_csr.py::TestSparseCSRCUDA::test_sampled_addmm_zero_sized_cuda_complex128
  • test_tensorboard.py::TestTensorBoardSummary::test_mesh

Fixes ROCM-989

@rocm-repo-management-api
Copy link
Copy Markdown

rocm-repo-management-api Bot commented Jan 17, 2026 •
edited
Loading

Jenkins build for 206c95fc0c8082c3c7818da44f62b3686c2573d0 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@dnikolaev-amd dnikolaev-amd force-pushed the dnikolaev/therock_rel2.9_fixes branch from 206c95f to 7a3f221 Compare January 19, 2026 15:04
@rocm-repo-management-api
Copy link
Copy Markdown

rocm-repo-management-api Bot commented Jan 19, 2026 •
edited
Loading

Jenkins build for 11230eedc7f3cd6f9c33c9d4e749ebeddb2a2b28 commit finished as NOT_BUILT
Links: Pipeline Overview / Build artifacts / Test Results

@rocm-repo-management-api
Copy link
Copy Markdown

rocm-repo-management-api Bot commented Jan 19, 2026 •
edited
Loading

Jenkins build for 11230eedc7f3cd6f9c33c9d4e749ebeddb2a2b28 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@rocm-repo-management-api
Copy link
Copy Markdown

rocm-repo-management-api Bot commented Jan 20, 2026 •
edited
Loading

Jenkins build for 49f243c563d35b58c8ae98ed6d40321b1fdc2857 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@dnikolaev-amd dnikolaev-amd force-pushed the dnikolaev/therock_rel2.9_fixes branch from 49f243c to b560377 Compare January 23, 2026 16:00
@rocm-repo-management-api
Copy link
Copy Markdown

rocm-repo-management-api Bot commented Jan 23, 2026 •
edited
Loading

Jenkins build for b56037734c901382419df7dcf7a5788483aca104 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@dnikolaev-amd dnikolaev-amd force-pushed the dnikolaev/therock_rel2.9_fixes branch from af9bed8 to b560377 Compare January 23, 2026 19:12
@rocm-repo-management-api
Copy link
Copy Markdown

rocm-repo-management-api Bot commented Jan 23, 2026 •
edited
Loading

Jenkins build for 2ae8e219662329805444071f5ea569c64efe66a6 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@dnikolaev-amd dnikolaev-amd force-pushed the dnikolaev/therock_rel2.9_fixes branch from 2ae8e21 to 18349dd Compare January 23, 2026 23:46
@rocm-repo-management-api
Copy link
Copy Markdown

rocm-repo-management-api Bot commented Jan 24, 2026 •
edited
Loading

Jenkins build for 18349dd4326ba40ab2e38743de3ab4433fe1baf1 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@rocm-repo-management-api
Copy link
Copy Markdown

rocm-repo-management-api Bot commented Jan 27, 2026 •
edited
Loading

Jenkins build for 3b64617f4a5202306180f17cbf7e871060924d78 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@rocm-repo-management-api
Copy link
Copy Markdown

rocm-repo-management-api Bot commented Jan 27, 2026 •
edited
Loading

Jenkins build for e9a385e22cc0af5334d318312e3434db8d5ee16b commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@rocm-repo-management-api
Copy link
Copy Markdown

rocm-repo-management-api Bot commented Jan 28, 2026 •
edited
Loading

Jenkins build for de7c7601688f9c58dc1ca831ffd2d42c89811334 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@rocm-repo-management-api
Copy link
Copy Markdown

rocm-repo-management-api Bot commented Jan 29, 2026 •
edited
Loading

Jenkins build for 1ece529b19e0b6c93699bfeb2bc49341d6c2b34e commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@dnikolaev-amd dnikolaev-amd force-pushed the dnikolaev/therock_rel2.9_fixes branch from 0cb881d to ebc388d Compare January 29, 2026 21:34
@dnikolaev-amd dnikolaev-amd marked this pull request as ready for review January 29, 2026 21:35
@rocm-repo-management-api
Copy link
Copy Markdown

rocm-repo-management-api Bot commented Jan 29, 2026

Jenkins build for ebc388d5e9ad129bb3a424709f978974f93b3542 commit finished as NOT_BUILT
Links: Pipeline Overview / Build artifacts / Test Results

@dnikolaev-amd dnikolaev-amd marked this pull request as draft January 29, 2026 23:16
@rocm-repo-management-api
Copy link
Copy Markdown

rocm-repo-management-api Bot commented Jan 30, 2026 •
edited
Loading

Jenkins build for ebc388d5e9ad129bb3a424709f978974f93b3542 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@rocm-repo-management-api
Copy link
Copy Markdown

rocm-repo-management-api Bot commented Jan 30, 2026 •
edited
Loading

Jenkins build for 814b22ab75964e7ca156fbb4c1e52f731e965223 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@dnikolaev-amd dnikolaev-amd marked this pull request as ready for review January 30, 2026 14:12
@dnikolaev-amd dnikolaev-amd requested a review from jeffdaily March 23, 2026 16:57
dnikolaev-amd and others added 4 commits March 24, 2026 22:12
@dnikolaev-amd
[release/2.9] UT fixes
5b62f9f
@0xjeffro @dnikolaev-amd
Fix protobuf test comparison by parsing proto instead of raw strings (p…
18afb18 
…ytorch#162644)

The tests were comparing raw exported strings for protobuf comparison, which is not backward/forward compatible with different versions of protobuf.

This PR parses the strings into protobuf and compares the protobufs directly, similar to what we did in assertImageProto.

Our test failed because we used a different version of protobuf, which output 44100.0 instead of 44100, which resulted in an error. However, they are equal, but only different in the exported strings.

Pull Request resolved: pytorch#162644
Approved by: https://github.com/justinchuby, https://github.com/Skylion007
@parsshar-RH @dnikolaev-amd
fix test_type_hints (pytorch#163150)
81d8e90 
Fixes pytorch#163149

### Summary:
Fixes mypy type checking failures in `test_type_hints` by consolidating typing imports and eliminating duplicate/conflicting import patterns that caused mypy to fail resolving type annotations.

### Impact:

- `test_type_hints` works fine now
- module: tests

Pull Request resolved: pytorch#163150
Approved by: https://github.com/Skylion007
@dnikolaev-amd
fix test_torchinductor_opinfo test_comprehensive_*
547af55
@dnikolaev-amd dnikolaev-amd force-pushed the dnikolaev/therock_rel2.9_fixes branch from 814b22a to 7a69cbb Compare March 24, 2026 22:53
@rocm-repo-management-api
Copy link
Copy Markdown

rocm-repo-management-api Bot commented Mar 24, 2026 •
edited
Loading

Jenkins build for 7a69cbb33c055d8a7a512b7807d3b73d7ddcbf35 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@rocm-repo-management-api
Copy link
Copy Markdown

rocm-repo-management-api Bot commented Mar 25, 2026 •
edited
Loading

Jenkins build for 06b12a8c85da12d3ec9e1332e12317808397a8f6 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pruthvistony pruthvistony Awaiting requested review from pruthvistony

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd

@pragupta pragupta Awaiting requested review from pragupta

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dnikolaev-amd @0xjeffro @parsshar-RH @chinmaydk99