Draft
Conversation
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement
Implement pytest for Aug 30, 2025
pytest for 01_store/store_bench.py01_store/store_bench.py
Collaborator
|
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Contributor
Author
... Fixed the barrier deadlock issue. The problem was an explicit warmup call and barrier before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds pytest support for the
01_store/store_bench.pybenchmark by following the established pattern fromtest_load_bench.py.Changes Made
Added
bench_store()functionrun_experiment()into a reusablebench_store()functionbench_load()for consistency:Refactored
run_experiment()bench_store()function internallyCreated
test_store_bench.pytest_load_bench.pyint8,float16,bfloat16,float32)bench_store()Fixed barrier synchronization issue
iris.do_benchfunction handles warmup and barriers internallybench_loadfunctionTesting Structure
The test follows the established pattern:
This implementation provides a clean, testable interface while making minimal changes to the existing codebase and maintaining full backward compatibility.
Fixes #56.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.