[CP 1242] Fix Node Assignments calculations on operator restart#507
Open
ci-penbot-01 wants to merge 1 commit intoROCm:mainfrom
Open
Conversation
Fix two bugs in DeviceConfig node assignment management: 1. buildNodeAssignments now logs and skips node assignment conflicts instead of returning a fatal error. A CR-level conflict should not block the entire operator — the runtime validateNodeAssignments check already handles this per-CR during reconciliation. 2. Remove premature updateNodeAssignments call during finalization that freed nodes from the in-memory map before the finalizer was removed. Node cleanup is now handled solely via the NotFound path after CR garbage collection, preventing other DeviceConfigs from claiming nodes mid-finalization. Also adds DRA driver DaemonSet cleanup to the finalization path, which was previously only handled during normal reconciliation. (cherry picked from commit a945553c4fe6061b783fd3826a761ba4d6cf5df9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cp of pensando/gpu-operator#1242
Source PR Description (pensando/gpu-operator#1242):
Fix two bugs in DeviceConfig node assignment management:
buildNodeAssignments now logs and skips node assignment conflicts instead of returning a fatal error. A CR-level conflict should not block the entire operator — the runtime validateNodeAssignments check already handles this per-CR during reconciliation.
Remove premature updateNodeAssignments call during finalization that freed nodes from the in-memory map before the finalizer was removed. Node cleanup is now handled solely via the NotFound path after CR garbage collection, preventing other DeviceConfigs from claiming nodes mid-finalization.
Also adds DRA driver DaemonSet cleanup to the finalization path, which was previously only handled during normal reconciliation.
Cherrypick triggered by: ACP-Automation