Merged
Conversation
* anr - fixes for applylabels step * multiple anr fixes (cherry picked from commit b33e4c9cc14ac69c6eab868e86bc20b295414c03)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cp of pensando/gpu-operator#1268
Source PR Description (pensando/gpu-operator#1268):
This PR addresses several issues in the remediation workflow handling:
GPUOP-603: The applyLabels step previously showed as "Succeeded" even when no custom labels were provided. It is now skipped when the label list is empty, giving clearer visibility into what the workflow actually executed.
GPUOP-604: The applyLabels and removeLabels steps previously treated label application failures as best-effort and always reported success. They now fail the workflow if any user-provided label operation fails, ensuring errors are surfaced rather than silently ignored.
GPUOP-605: Fixed a corner case where workload resume was not triggered when the recoveryPolicy limit was reached.
GPUOP-609: During helm uninstall, the operator was unconditionally deleting the remediation ConfigMap, even if it was user-created. The cleanup now only removes operator-created ConfigMaps, leaving user-provided ones intact.
GPUOP-610: Fixed autoStartWorkflow not taking effect when set via --set during helm install. The Helm template used {{- with }} to render the field, which treats false as a falsy value and skips the block entirely. Replaced with {{- if hasKey }} to correctly handle boolean values.
GPUOP-611: Fixed the testRunnerImageSecret parameter not being passed down to the workflow step's script, causing the secret to be ignored during workflow execution.
Cherrypick triggered by: ACP-Automation