Conversation
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
There was a problem hiding this comment.
Pull request overview
This PR formalizes Triton as an explicit runtime dependency (minimum 3.6.0) and simplifies the Triton/Gluon codepaths by removing legacy version-branching and compatibility shims across kernels and tests.
Changes:
- Add
triton>=3.6.0toinstall_requiresinsetup.py. - Remove Triton version-detection helpers and conditional branches targeting older Triton versions across Gluon/Triton kernels.
- Update Triton op tests to drop Triton 3.5-specific logic/skips and disable AOT usage where incompatible.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Declares Triton (>=3.6.0) as a required dependency for non-Windows installs. |
| op_tests/triton_tests/gemm/basic/test_gemm_afp4wfp4.py | Removes Triton-3.5 AOT gating; forces use_aot=False for preshuffle path. |
| op_tests/triton_tests/gemm/basic/test_gemm_a8w8.py | Removes Triton-3.5-specific skip for FP8 split-K lowering. |
| aiter/ops/triton/gluon/triton_version.py | Deletes version parsing/constants module now made obsolete by the min-version requirement. |
| aiter/ops/triton/gluon/pa_decode_gluon.py | Removes version-dependent MFMA/logits layout branching; standardizes on >=3.6 layout/shape. |
| aiter/ops/triton/gluon/gemm_afp4wfp4.py | Removes version-dependent MFMA instruction shape selection. |
| aiter/ops/triton/gluon/gemm_a8w8.py | Removes version-dependent MFMA shape/width branching; assumes >=3.6 MFMA shapes. |
| aiter/ops/triton/attention/pa_mqa_logits.py | Drops legacy Triton version branching and unconditionally uses Gluon ASTSource path consistent with min-version. |
| aiter/ops/triton/_triton_kernels/gated_delta_rule/gated_delta_rule_utils.py | Removes outdated “recommended Triton>=3.2” warning logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6ec6bef to
59bf1e8
Compare
brunomazzottiamd
left a comment
There was a problem hiding this comment.
@micmelesse, it LGTM! I've left a AOT cleanup suggestion from other PR, apply it at your own judgement.
9789498 to
ff9d6a3
Compare
ff9d6a3 to
213bb95
Compare
|
Test failure report: Triton Tests (MI35X) / Shard 0 - It's a know issue that's under investigation, it isn't a blocker for merging. Triton Tests (MI325) / Shard 5 and Triton Tests (MI35X) / Shard 5 - It's a recently discovered issue caused by Triton Tests (MI35X) / Shard 7 - Fixed by #2723, it isn't a blocker for merging. @micmelesse, can you please check what's going on with Flash Attention Integration / Flash Attention - Triton / MI35X (1 GPU) job? If we figure this out then we're good to merge. FYI: @azaidy |
|
|
|
@brunomazzottiamd I will rebase and fix the Flash Attention test failure. |
Motivation
This PR declares aiter's dependency on triton in setup.py. This is standard practice for python libraries. We declare a minimum version of
3.6.0. We remove a lot of ad-hoc code that was branching on triton versions.Technical Details
Test Plan
Test Result
Submission Checklist