Skip to content

[TRITON] Prevent NUM_KSPLIT from reducing K dim below GROUP_K#2661

Merged
vgokhale merged 3 commits intomainfrom
vinayak/fix_a8w8_blockscale
Apr 13, 2026
Merged

[TRITON] Prevent NUM_KSPLIT from reducing K dim below GROUP_K#2661
vgokhale merged 3 commits intomainfrom
vinayak/fix_a8w8_blockscale

Conversation

@vgokhale
Copy link
Copy Markdown
Contributor

@vgokhale vgokhale commented Apr 9, 2026

This sets NUM_KSPLIT such that the K dim doesn't drop below GROUP_K.

@vgokhale vgokhale requested review from a team, azaidy and k50112113 April 9, 2026 02:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:triton-355 Run Triton tests on MI355 in addition to MI325
ci:sglang SGLang integration tests
ci:atom ATOM benchmark (DeepSeek-R1 + GPT-OSS)
ci:vllm vLLM benchmark
ci:all All of the above

Add labels via the sidebar or gh pr edit 2661 --add-label <label>

k50112113
k50112113 previously approved these changes Apr 9, 2026
@vgokhale vgokhale changed the title Prevent NUM_KSPLIT from reducing K dim below GROUP_K [TRITON] Prevent NUM_KSPLIT from reducing K dim below GROUP_K Apr 9, 2026
Copy link
Copy Markdown
Contributor

@azaidy azaidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgokhale vgokhale merged commit 1a8fb17 into main Apr 13, 2026
43 of 45 checks passed
@vgokhale vgokhale deleted the vinayak/fix_a8w8_blockscale branch April 13, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants