first addition of skills#324
Open
AtlantaPepsi wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces initial .claude/skills documentation and example artifacts to guide running and debugging TransferBench (including presets, config syntax, env vars, and multi-rank workflows).
Changes:
- Added a
transferbench-runskill with runnable recipes plus references for presets, env vars, and config-file grammar. - Added a
transferbench-debugskill with symptom-driven troubleshooting guides and introspection helpers. - Added example configs and shell scripts for multi-node launch and topology/preset probing.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .claude/skills/transferbench-run/SKILL.md | Run-side skill overview, invocation, recipes, and references. |
| .claude/skills/transferbench-run/references/presets.md | Curated list of common presets and selection guidance. |
| .claude/skills/transferbench-run/references/env-vars.md | Curated env-var guide organized by topic. |
| .claude/skills/transferbench-run/references/config-format.md | Config grammar summary with examples and idioms. |
| .claude/skills/transferbench-run/examples/multi-node.sh | Template mpirun launcher with env propagation. |
| .claude/skills/transferbench-run/examples/basic-p2p.cfg | Minimal peer-to-peer config examples. |
| .claude/skills/transferbench-run/examples/advanced-mixed.cfg | Advanced-mode config examples (per-transfer bytes/SEs). |
| .claude/skills/transferbench-debug/SKILL.md | Debug-side skill overview and triage flow. |
| .claude/skills/transferbench-debug/references/verbose-introspection.md | Debug-focused env vars + introspection command reference. |
| .claude/skills/transferbench-debug/references/multi-rank-debug.md | Layered multi-rank (MPI/socket/RDMA) troubleshooting guide. |
| .claude/skills/transferbench-debug/references/common-failures.md | Symptom → cause → fix catalog for common failures. |
| .claude/skills/transferbench-debug/examples/topology-probe.sh | Script to capture banner/presets/envvars/help and optionally dump a preset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+15
to
+17
| BINARY="${BINARY:-./TransferBench}" | ||
| [[ -x "./TransferBenchCuda" ]] && BINARY="${BINARY/TransferBench/TransferBenchCuda}" | ||
| [[ -x "$BINARY" ]] || { echo "ERROR: $BINARY not found or not executable"; exit 1; } |
Comment on lines
+10
to
+12
| # 1. Same binary on every node | ||
| for h in node0 node1; do ssh $h md5sum /home/timhu102/tBench/TransferBenchCuda; done | ||
|
|
Comment on lines
+1
to
+4
| --- | ||
| name: transferbench-run | ||
| description: Use when the user wants to *run* TransferBench (the ROCm/CUDA memory-transfer benchmarking tool from AMD) — benchmarking, profiling, or measuring GPU/CPU/NIC bandwidth and latency. Covers writing config files, picking the right preset (a2a, p2p, sweep, nicp2p, podp2p, etc.), tuning environment variables, and launching single-node or multi-node (MPI / socket) runs. Does NOT cover building the binary from source, modifying its source code, or extending it with new presets/executors — for those, defer to a separate skill or the codebase itself. | ||
| --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist