Skip fuse_horizontal pass on dynamic shaped inputs#5017
Open
CharlieL7 wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Skips fuse_horizontal gather fusion candidates when any input shape is dynamic, avoiding compilation-time errors from calling lens() on dynamic shapes during horizontal fusion.
Changes:
- Add a dynamic-shape guard in
same_table_gather_horizontal_fusion::is_candidate. - Add the same guard in
gather_horizontal_fusion::is_candidate.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5017 +/- ##
===========================================
+ Coverage 92.69% 92.72% +0.03%
===========================================
Files 596 596
Lines 31603 31739 +136
===========================================
+ Hits 29292 29427 +135
- Misses 2311 2312 +1
🚀 New features to boost your workflow:
|
Regressions detected 🔴 |
|
ahsan-ca
approved these changes
Jun 27, 2026
ahsan-ca
left a comment
Contributor
There was a problem hiding this comment.
Looks good. A unit test might be helpful.
shivadbhavsar
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fuse_horizontalcallinglens()on a dynamic shape.Technical Details
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable