Bump CAPI version number for LDS usage estimation function#4998
Draft
justinrosner wants to merge 1 commit into
Draft
Bump CAPI version number for LDS usage estimation function#4998justinrosner wants to merge 1 commit into
justinrosner wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates MIGraphX’s GPU MLIR integration to match rocMLIR’s bumped MIGraphX CAPI version (to pick up the newly added mlirMIGraphXLDSUsageFitsArch() function on the rocMLIR side), and pins the dependency to a rocMLIR commit that provides that API.
Changes:
- Update the compile-time compatibility check to require
MLIR_MIGRAPHX_DIALECT_API_VERSION == 6. - Bump the pinned
ROCm/rocMLIRcommit inrequirements.txt.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/targets/gpu/mlir.cpp |
Updates the rocMLIR CAPI version gate from 5 to 6 to ensure ABI/API compatibility. |
requirements.txt |
Pins rocMLIR to a newer commit hash expected to expose CAPI version 6. |
Collaborator
|
Converted to draft until the rocmlir PR gets merged. |
Regressions detected 🔴 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rocMLIR bumped its MIGraphX CAPI from version 5 to 6 to add
mlirMIGraphXLDSUsageFitsArch(), so this PR bumps that API version and the rocMLIR commit hash to go with that.This PR should only be merged once ROCm/rocMLIR#2400 get's merged into rocMLIR's develop.
Technical Details
MLIR_MIGRAPHX_DIALECT_API_VERSIONfrom version 5 -> 6Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable