Skip to content

add minimal JSON schema#116

Merged
cjyetman merged 17 commits intomainfrom
json-schema
May 28, 2025
Merged

add minimal JSON schema#116
cjyetman merged 17 commits intomainfrom
json-schema

Conversation

@cjyetman
Copy link
Copy Markdown
Contributor

@cjyetman cjyetman commented May 27, 2025

Adds a JSON schema to validate frontend/src/data/scenarios_metadata.json

  • adds schema frontend/pbtar_schame.json
  • adds acv-cli to frontend/package.json
  • updates frontend/package-lock.json appropriately with the addition of acv-cli
  • adds a json:check "script" to frontend/package.json to run the JSON validator
  • adds a GitHub action to run the JSON validator whenever frontend/pbtar_schame.json, frontend/src/data/scenarios_metadata.json, or .github/workflows/frontend-json.yml is changed

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/pbtar_api/models
   pydantic_models.py59590%1–101
src/pbtar_api/routers
   endpoints.py452544%15, 20–21, 30–33, 40–43, 50–53, 60–63, 72–86
src/pbtar_api/services
   auth.py12375%16–18
   db.py14471%18–22
TOTAL2089156% 

Tests Skipped Failures Errors Time
6 0 💤 0 ❌ 0 🔥 2.822s ⏱️

@cjyetman cjyetman marked this pull request as ready for review May 28, 2025 07:59
@cjyetman cjyetman requested a review from jdhoffa May 28, 2025 08:05
Comment thread frontend/package.json Outdated
@jdhoffa
Copy link
Copy Markdown
Collaborator

jdhoffa commented May 28, 2025

Testing locally now

Comment thread frontend/package.json Outdated
Comment thread frontend/pbtar_schema.json
@cjyetman cjyetman dismissed AlexAxthelm’s stale review May 28, 2025 10:25

minimal require and additionalProperties settings have been added

@cjyetman cjyetman requested a review from jdhoffa May 28, 2025 10:26
Copy link
Copy Markdown
Collaborator

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@cjyetman cjyetman merged commit 124b312 into main May 28, 2025
8 checks passed
@cjyetman cjyetman deleted the json-schema branch May 28, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants