Handling malformed matrices gracefully#11
Merged
RLado merged 3 commits intoRLado:masterfrom Feb 20, 2025
Merged
Conversation
Owner
|
Thanks for the proposal. I think you are right, it is generally a bad idea to panic on a library that other developers are expected to use. Changing those |
Contributor
Author
|
Okay, I've switched the String to be an enum which implements std::error::Error, that should be nicer for library users to consume |
RLado
approved these changes
Feb 20, 2025
Owner
RLado
left a comment
RLado
left a comment
There was a problem hiding this comment.
Looks good! Thank you for the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For my use-case, I'm not guaranteed to be provided a solvable matrix; instead of panicking inside rsparse when this happens, I want to be able to handle the error. This PR is a crude draft; all I did was replace
panic!()withResult<(), String>. If this feature is wanted, I can convert the String into athiserrorenum, which would be easier for libraries to consume. Open to suggestions!