perf: Use LinkedHashSet instead of array backed collection in ObjectsStore#98
Open
wchill wants to merge 1 commit intoREAndroid:mainfrom
Open
perf: Use LinkedHashSet instead of array backed collection in ObjectsStore#98wchill wants to merge 1 commit intoREAndroid:mainfrom
wchill wants to merge 1 commit intoREAndroid:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97
ObjectsStore does not provide an API for random access, so there is no point in using a list or array because we get no benefit from constant-time random access, as long as we can guarantee ordering (which LinkedHashSet does). This speeds up add, remove, and contains operations from O(n) to O(1), which prevents the degenerate case mentioned in #97.
The underlying data structure is not exposed (because all accesses are proxied through ObjectsStore), so we don't need to worry about the extra functions that ObjectsList/ArrayCollection provides.
Speedup: approximately 4 minutes spent for decode/modify/encode/zipalign/sign total -> 26 seconds on a Ryzen AI 9 HX 370.