Fix CodeFactor maintainability and style issues in func_discord_data.R#57
Merged
smasongarrison merged 3 commits intomainfrom Feb 21, 2026
Merged
Conversation
Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix maintainability and style issues in R func_discord_data.R
Fix CodeFactor maintainability and style issues in func_discord_data.R
Feb 21, 2026
Signed-off-by: Mason Garrison <garrissm@wfu.edu>
smasongarrison
approved these changes
Feb 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
=======================================
Coverage 91.20% 91.20%
=======================================
Files 7 7
Lines 853 853
=======================================
Hits 778 778
Misses 75 75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five maintainability and five style violations flagged by CodeFactor in
R/func_discord_data.R.Changes
Safe sequence iteration — replaced
1:nrow(...)withseq_len(nrow(...))and1:length(...)withseq_along(...)to avoid off-by-one errors on zero-length inputs:Implicit returns — removed explicit
return(output)/return(df)calls at function tails (lines 187, 191, 310) in favour of R's implicit return convention.Indentation — corrected continuation-line indentation inside
if (!valid_ids(...))calls from 4 to 8 spaces (lines 109, 223).Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.