Fix style and maintainability issues in helpers_regression.R

[Copilot]

Addresses 26 CodeFactor findings in R/helpers_regression.R: long lines, oversized function name, explicit return() calls, and wrong scalar logical operators.

Changes

• Line length: Wrapped 14 lines exceeding 120 chars in both doc comments and code blocks
• Function rename: check_sibling_order_ram_optimized (34 chars) → check_sibling_order_ram to satisfy the 30-char name limit; call site updated
• Implicit returns: Removed 8 explicit return() calls — R's implicit return makes these redundant per tidyverse style
• Logical operators: | → || and & → && in scalar conditionals (if expressions should use short-circuit operators)
• Tests added: New tests/testthat/test-helpers_regression.R with 8 tests covering the changed code paths in check_discord_errors, valid_ids, check_sibling_order_ram, and check_sibling_order_fast

# Before
if (base::sum(base::grepl(pair_identifiers[1], base::names(data))) == 0 | base::sum(...) == 0) {
if (!base::is.null(sex) & !base::is.null(race) && sex == race) {

# After
if (base::sum(base::grepl(pair_identifiers[1], base::names(data))) == 0 ||
  base::sum(base::grepl(pair_identifiers[2], base::names(data))) == 0) {
if (!base::is.null(sex) && !base::is.null(race) && sex == race) {

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Fix 2 Maintainability, 24 Style issues in R\helpers_regression.R</issue_title>
<issue_description>CodeFactor found multiple issues last seen at c9493bd:

Use || in conditional expressions.

• R\helpers_regression.R:378

Use && in conditional expressions.

• R\helpers_regression.R:381

Lines should not be more than 120 characters. This line is 132 characters.

• R\helpers_regression.R:5
• R\helpers_regression.R:27

Variable and function names should not be longer than 30 characters.

• R\helpers_regression.R:39

Lines should not be more than 120 characters. This line is 199 characters.

• R\helpers_regression.R:49
• R\helpers_regression.R:78

Use implicit return behavior; explicit return() is not needed.

• R\helpers_regression.R:66
• R\helpers_regression.R:93
• R\helpers_regression.R:180
• R\helpers_regression.R:294
• R\helpers_regression.R:349
• R\helpers_regression.R:404
• R\helpers_regression.R:406
• R\helpers_regression.R:409

Lines should not be more than 120 characters. This line is 236 characters.

• R\helpers_regression.R:99

Lines should not be more than 120 characters. This line is 122 characters.

• R\helpers_regression.R:100

Lines should not be more than 120 characters. This line is 141 characters.

• R\helpers_regression.R:273

Lines should not be more than 120 characters. This line is 140 characters.

• R\helpers_regression.R:276

Lines should not be more than 120 characters. This line is 138 characters.

• R\helpers_regression.R:283

Lines should not be more than 120 characters. This line is 195 characters.

• R\helpers_regression.R:286

Lines should not be more than 120 characters. This line is 176 characters.

• R\helpers_regression.R:354

Lines should not be more than 120 characters. This line is 147 characters.

• R\helpers_regression.R:373

Lines should not be more than 120 characters. This line is 149 characters.

• R\helpers_regression.R:376

Lines should not be more than 120 characters...

• Fixes Fix 2 Maintainability, 24 Style issues in R\helpers_regression.R #52

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (73f17f8) to head (c74bc14).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   91.20%   92.25%   +1.04%     
==========================================
  Files           7        7              
  Lines         853      878      +25     
==========================================
+ Hits          778      810      +32     
+ Misses         75       68       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[smasongarrison]

@copilot can you help improve the patch coverage by adding a couple of tests?

[Copilot]

@copilot can you help improve the patch coverage by adding a couple of tests?

Added tests/testthat/test-helpers_regression.R (commit c74bc14) with 8 tests covering the changed code paths:

• check_discord_errors: invalid id, sex, and race columns; missing first pair identifier; missing second pair identifier (specifically exercising the || fix); sex == race equality (exercising the && fix)
• valid_ids: duplicate id column triggers a warning and falls back to row-wise id
• check_sibling_order_ram (fast = FALSE): NA outcome value stops with an error
• check_sibling_order_fast (fast = TRUE): NA outcome value stops with an error