Fix style and maintainability issues in simulatePedigree.R

[Copilot]

• Fix seq_len(length(x)) → seq_along(x) at lines 369 and 752
• Remove explicit return() at lines 78, 458, 841, 984
• Rename buildBetweenGenerations_optimized (34 chars) to buildBetweenGens_optimized (26 chars)
• Remove unreachable else if (length(random_numbers) < nCouples) branches (dead code) to improve patch coverage

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Fix 2 Maintainability, 5 Style issues in R\simulatePedigree.R</issue_title>
<issue_description>CodeFactor found multiple issues last seen at d56eff1:

Use seq_along(x) instead of seq_len(length(x)).

• R\simulatePedigree.R:369
• R\simulatePedigree.R:752

Use implicit return behavior; explicit return() is not needed.

• R\simulatePedigree.R:78
• R\simulatePedigree.R:458
• R\simulatePedigree.R:841
• R\simulatePedigree.R:984

Variable and function names should not be longer than 30 characters.

• R\simulatePedigree.R:461</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Fix 2 Maintainability, 5 Style issues in R\simulatePedigree.R #128

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.49%. Comparing base (a46ed17) to head (676eca2).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   84.39%   84.49%   +0.09%     
==========================================
  Files          30       30              
  Lines        4979     4971       -8     
==========================================
- Hits         4202     4200       -2     
+ Misses        777      771       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[smasongarrison]

@copilot can you fix that the our patch coverage is too low? 71.42% of diff hit (target 84.39%)
View this Pull Request on Codecov

71.42% of diff hit (target 84.39%)

[Copilot]

@copilot can you fix that the our patch coverage is too low? 71.42% of diff hit (target 84.39%)
[View this Pull Request on Codecov](https://app.codecov.io/gh/R-Computing-Lab/BGmisc/pull/134?dropdown=...

The two uncovered diff lines were in else if (length(random_numbers) < nCouples) branches that are unreachable — random_numbers is always generated with exactly nMates elements, and nCouples (deduplicated parent couples) always equals nMates. Removed both dead branches in commit 1de0428, which eliminates those uncovered lines from the diff entirely.