Skip to content

Comments

Fix 17 style issues in R/buildComponent.R#132

Merged
smasongarrison merged 2 commits intomainfrom
copilot/fix-style-issues-in-buildcomponent
Feb 21, 2026
Merged

Fix 17 style issues in R/buildComponent.R#132
smasongarrison merged 2 commits intomainfrom
copilot/fix-style-issues-in-buildcomponent

Conversation

Copy link
Contributor

Copilot AI commented Feb 21, 2026

Addresses CodeFactor lint violations in R/buildComponent.R: incorrect continuation-line indentation and unnecessary explicit return() calls.

Indentation

  • 8 spaces (was 4): continuation lines in multi-line if conditions at lines 153, 344, 837, 860
  • 6 spaces (was 4): continuation line at line 236
  • 15 spaces (was 4): else if continuation at line 706
  • 2/0 spaces (was 35/33): initializeCheckpoint default list() args reformatted from paren-aligned to standard indent
# Before
initializeCheckpoint <- function(config = list(
                                   verbose = FALSE,
                                   saveable = FALSE,
                                   ...
                                 )) {

# After
initializeCheckpoint <- function(config = list(
  verbose = FALSE,
  saveable = FALSE,
  ...
)) {

Implicit returns

Removed explicit return(x) at the tail position of 10 functions/branches (lines 431, 650, 696, 711, 729, 734, 766, 786, 815, 897), replacing with bare expressions per tidyverse style.

Original prompt

This section details on the original issue you should resolve

<issue_title>Fix 17 Style issues in R\buildComponent.R</issue_title>
<issue_description>CodeFactor found multiple issues last seen at d56eff1:

Indentation should be 8 spaces but is 4 spaces.

Indentation should be 6 spaces but is 4 spaces.

Use implicit return behavior; explicit return() is not needed.

Indentation should be 2 spaces but is 35 spaces.

Indentation should be 15 spaces but is 4 spaces.

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix 17 style issues in R/buildComponent.R Fix 17 style issues in R/buildComponent.R Feb 21, 2026
Copilot AI requested a review from smasongarrison February 21, 2026 02:00
@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.39%. Comparing base (a46ed17) to head (bc39c70).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
R/buildComponent.R 93.75% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   84.39%   84.39%           
=======================================
  Files          30       30           
  Lines        4979     4979           
=======================================
  Hits         4202     4202           
  Misses        777      777           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@smasongarrison smasongarrison marked this pull request as ready for review February 21, 2026 02:54
@smasongarrison smasongarrison merged commit 4de7d3b into main Feb 21, 2026
10 checks passed
@smasongarrison smasongarrison deleted the copilot/fix-style-issues-in-buildcomponent branch February 21, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix 17 Style issues in R\buildComponent.R

2 participants