fix: rolldown-vite support (static paths + native import-analysis)#8669
Open
briancarbone wants to merge 2 commits into
Open
Conversation
…build Rolldown can re-emit the __QWIK_ROUTER_*_ARRAY__ placeholders as backtick template literals, which the post-build regex (single/double quotes only) failed to replace — breaking isStaticPath so static assets 404'd via SSR fallthrough. Accept backticks too.
Under rolldown-vite (Vite 8), native:import-analysis-build (the Rust counterpart of vite:build-import-analysis) still injects __vitePreload wrappers into QRL chunks. Add it to the removal list so Qwik's own preloader handles dynamic imports.
🦋 Changeset detectedLatest commit: 0bdae28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Two small build-tooling fixes required to build a Qwik Router app with rolldown-vite (Vite 8). Both surfaced while testing the
rolldown-vite-supportbranch with Vite 8, and both let me drop workarounds I'd been carrying in my app's root and adaptervite.config.ts.1.
fix(router)- backtick-wrapped static-path placeholdersRolldown can re-emit the
__QWIK_ROUTER_STATIC_PATHS_ARRAY__/__QWIK_ROUTER_NOT_FOUND_ARRAY__placeholders as backtick template literals. The adapter'spost-build.tsinjection regex only matched single/double quotes, so the placeholders were never substituted:isStaticPathalways returnedfalseand every static asset 404'd through the SSR fallthrough. The regex now also accepts backticks.2.
fix(vite)- strip rolldown-vite's native import-analysis pluginQwik already removes Vite's JS
vite:build-import-analysisplugin (its__vitePreloadmachinery is redundant with Qwik's own preloader). Under rolldown-vite that plugin has a native Rust counterpart,native:import-analysis-build, which wasn't being removed, so it kept injecting__vitePreloadwrappers and__VITE_PRELOAD__markers into QRL chunks, leaving orphaned identifiers. Added the native name to the existing removal list.Checklist
patchchangesets:@qwik.dev/router,@qwik.dev/core)