fix(qwik-city): spa routeInternal and routeLocation url mismatch#8234
Merged
shairez merged 2 commits intoQwikDev:mainfrom Jan 13, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 6abc9fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gioboa
reviewed
Jan 10, 2026
Member
gioboa
left a comment
There was a problem hiding this comment.
Can you add the changeset file?
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Member
Author
|
thanks for the reminder @gioboa 😄 |
Member
Author
|
Keeping as draft for now as I'd like to test it out on a production app. |
shairez
approved these changes
Jan 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Because of #8097, the routeLocation and routeStateInternal url origins could get out of sync in case the envUrl was setup dynamically. This should fix the issue and hopefully not be problematic for anyone.
I'll add a test for it once we have vitest browser mode for component & hooks testing.
Checklist
pnpm change