Skip to content

Use hardcoded dates in Metadata test#10

Merged
MarcinZiabek merged 2 commits into
mainfrom
copilot/hardcode-dates-in-metadata-method
Jun 1, 2026
Merged

Use hardcoded dates in Metadata test#10
MarcinZiabek merged 2 commits into
mainfrom
copilot/hardcode-dates-in-metadata-method

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 1, 2026

The Metadata test was computing CreationDate and ModificationDate dynamically using DateTimeOffset.Now, making the generated PDF output non-deterministic and causing size assertions to be unreliable.

Changes

  • Replaced dynamic DateTimeOffset.Now - TimeSpan.FromHours(...) expressions with fixed concrete values:
    • CreationDate: 2026-05-10T12:34:56Z
    • ModificationDate: 2026-06-13T22:20:18Z
CreationDate = new SkDateTime(new DateTimeOffset(2026, 5, 10, 12, 34, 56, TimeSpan.Zero)),
ModificationDate = new SkDateTime(new DateTimeOffset(2026, 6, 13, 22, 20, 18, TimeSpan.Zero)),

@MarcinZiabek MarcinZiabek marked this pull request as ready for review June 1, 2026 17:00
Copilot AI review requested due to automatic review settings June 1, 2026 17:00
@MarcinZiabek MarcinZiabek merged commit ad80c77 into main Jun 1, 2026
4 of 5 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants