Conversation
pyo.init_notebook_mode(connected=True) outputs only text/html which the LaTeX builder cannot render. With -W (warnings-as-errors) this kills the PDF build. The lecture uses kaleido for static PNG export so this call is not needed for the book build. Closes #308
✅ Deploy Preview for lustrous-melomakarona-3ee73e ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mmcky
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyo.init_notebook_mode(connected=True)inknowing_forecasts_of_others.mdoutputs onlytext/html(it injects the plotly.js library into the notebook). The LaTeX/PDF builder has no way to render HTML output, so with-W(warnings-as-errors) this single warning kills the PDF build.Fix
Commented out the
pyo.init_notebook_mode(connected=True)call and added a note that it should be uncommented when running interactively in a notebook. This call is not needed for the book build since all plotly figures in this lecture already useImage(fig.to_image(format="png", engine="kaleido"))for static PNG export.Closes #308