fix(shell): Take a bigger margin for terminal size#2811
Open
erebe wants to merge 1 commit into
Open
Conversation
* Use the shell container size instead of the global one * increase the cell height to avoid line wrapping
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #2811 +/- ##
===========================================
- Coverage 47.60% 47.21% -0.39%
===========================================
Files 783 1176 +393
Lines 19626 25439 +5813
Branches 5954 7544 +1590
===========================================
+ Hits 9342 12010 +2668
- Misses 8635 11390 +2755
- Partials 1649 2039 +390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When openning the shell websocket, the frontend compute the width and height of the terminal to forward it to the backend.
Today, the width and height are too big causing line wrapping
Before

After
