Skip to content

refactor(cluster-action-toolbar): change toolbar layout and components#2477

Open
TheoGrandin74 wants to merge 1 commit intofeat/new-nav/storage-settingsfrom
feat/new-nav/cluster-buttons
Open

refactor(cluster-action-toolbar): change toolbar layout and components#2477
TheoGrandin74 wants to merge 1 commit intofeat/new-nav/storage-settingsfrom
feat/new-nav/cluster-buttons

Conversation

@TheoGrandin74
Copy link
Contributor

Summary

  • Updated ClusterActionToolbar to accept a "heading" variant prop for better customization.
  • Replaced ActionToolbar.Button with Button component for consistency.
  • Adjusted button sizes and styles based on the variant.
  • Modified ClusterOverview to pass the new variant prop.
  • Updated ClusterCard to utilize the card variant for the action toolbar.
  • Improved layout and spacing in the toolbar and card components.

Issue:

Screenshots / Recordings

image image

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat/new-nav/storage-settings@e7ade77). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../cluster-action-toolbar/cluster-action-toolbar.tsx 50.00% 5 Missing and 5 partials ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##             feat/new-nav/storage-settings    #2477   +/-   ##
================================================================
  Coverage                                 ?   43.39%           
================================================================
  Files                                    ?      671           
  Lines                                    ?    15400           
  Branches                                 ?     4530           
================================================================
  Hits                                     ?     6683           
  Misses                                   ?     7507           
  Partials                                 ?     1210           
Flag Coverage Δ
unittests 43.39% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant